fix for re-render issue #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked for me. I'm no longer experiencing re-renders caused bu actions.
| // This could leads to issues like below: | ||
| // https://github.com/kadirahq/react-storybook/issues/81 | ||
| ReactDOM.unmountComponentAtNode(rootEl); | ||
| if (selectedKind !== previousKind || previousStory !== selectedStory) { |
There was a problem hiding this comment.
Add a comment on why we do this and add the link to the related issue.
|
Thanks. |
|
Released with |
wyattdanger
pushed a commit
to wyattdanger/react-storybook
that referenced
this pull request
Apr 26, 2016
* fix for re-render issue This worked for me. I'm no longer experiencing re-renders caused bu actions. * changed const to let * added comment and reference to issue * fixed typo * code style
ndelangen
pushed a commit
that referenced
this pull request
Apr 5, 2017
Updated react-native in peerDependencies
ghost
mentioned this pull request
|
View your CI Pipeline Execution ↗ for commit f1510b4
☁️ Nx Cloud last updated this comment at |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116 This worked for me. I'm no longer experiencing re-renders caused bu actions.