-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Fix storybook-build manager-head.html bug
#1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 13.74% 13.75% +<.01%
==========================================
Files 207 207
Lines 4633 4632 -1
Branches 504 511 +7
==========================================
Hits 637 637
+ Misses 3564 3558 -6
- Partials 432 437 +5
Continue to review full report at Codecov.
|
storybook-build manager-head.html bug
tmeasday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works

Issue: #1239
What I did
getHeadHtmltogetPreviewHeadHtmlto make it more explicitgetManagerHeadHtmlin both dev and build modeschmod +x build.jsHow to test
No preview/manager head case:
Verify that there is no
undefinedacross the top of the screenPreview/manager head case:
Run the same tests as above, verify that there is
manageracross the top of the screen andpreviewacross the top of the preview iframe.