This repository was archived by the owner on Oct 19, 2022. It is now read-only.
Target .NET 4.5.1 as well as .NET Standard 1.6 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to build ASP.NET Core applications that target the .NET 4.5 framework. Because this package only targets .NET Standard 1.6 it cannot be imported into ASP.NET Core projects that do so. This is a very simple change and is risk free, while broadening the appeal of solution.
Member
|
Hey @JSkimming, thanks for the PR! I didn't realize anyone was building ASP.NET Core applications on desktop .NET. I'm curious, what's the reasoning there? |
Contributor
Author
|
Hi @nbarbettini, there's several reasons, we have two.
So we want to use the latest ASP.NET in our new applications, but still need to target .NET 4.5. |
Contributor
Author
|
👍 |
Contributor
Author
|
Hi @nbarbettini, Can you push an update to NuGet with this change? A minor (0.4.0) or patch increment (0.3.3) would seem appropriate. It's not really changing the API. |
Member
|
Sorry for the delay @JSkimming, yesterday was a holiday here in the US. 🎉 Published as v0.3.3: https://www.nuget.org/packages/Stormpath.AspNetCore/0.3.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to build ASP.NET Core applications that target the .NET 4.5 framework. Since this package only targets .NET Standard 1.6 it cannot be imported into ASP.NET Core projects that do so. This results in the following build error:
This is a very simple change and is risk free, while broadening the appeal of solution.