Skip to content

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 17, 2024

due to {runtime.platform.path} usage when other platform reference the core.

  • {runtime.platform.path}:
    The absolute path of the board platform folder (i.e. the folder containing boards.txt)
  • {build.core.path}:
    The path to the selected board's core folder (inside the core platform, for example hardware/STMicroelectronics/stm32/core/arduino)

Ref:
https://arduino.github.io/arduino-cli/1.0/platform-specification/#referencing-another-core-variant-or-tool

Fixes #2445

due to {runtime.platform.path} usage when other platform
reference the core.

- {runtime.platform.path}:
  The absolute path of the board platform folder
  (i.e. the folder containing boards.txt)
- {build.core.path}:
  The path to the selected board's core folder (inside the
  core platform, for example hardware/STMicroelectronics/stm32/core/arduino)

Ref:
https://arduino.github.io/arduino-cli/1.0/platform-specification/#referencing-another-core-variant-or-tool

Fixes stm32duino#2445

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm added the fix 🩹 Bug fix label Jul 17, 2024
@fpistm fpistm added this to the 2.8.1 milestone Jul 17, 2024
@fpistm fpistm changed the title fix(platform): core reference broken and add default vid/pid definition fix(platform): core reference broken Jul 17, 2024
@fpistm fpistm merged commit f4a3409 into stm32duino:main Jul 18, 2024
23 checks passed
@fpistm fpistm deleted the core_reference branch July 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
Development

Successfully merging this pull request may close these issues.

2.8.0 breaks core reference
1 participant