Skip to content

HardwareTimer: fix typo in comments and obvious ICPolarity wrong setting #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2021
Merged

HardwareTimer: fix typo in comments and obvious ICPolarity wrong setting #1548

merged 2 commits into from
Nov 23, 2021

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Nov 17, 2021

Summary
HardwareTimer:

  • fix typo in comments
  • fix obvious ICPolarity wrong setting

@ABOSTM ABOSTM requested a review from fpistm November 17, 2021 15:30
fpistm
fpistm approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added the fix 🩹 Bug fix label Nov 17, 2021
@fpistm fpistm added this to the 2.2.0 milestone Nov 17, 2021
fpistm
fpistm requested changes Nov 23, 2021
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ABOSTM
please could you resolve the conflict in order to be able to merge ?

@fpistm fpistm merged commit 3c192ba into stm32duino:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
fix 🩹 Bug fix
Projects
None yet
Milestone
2.2.0 🎄 🎅
Development

Successfully merging this pull request may close these issues.
2 participants
@ABOSTM @fpistm