- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3
 
Add Contributing Guidelines #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthew Burket <[email protected]>
Signed-off-by: Matthew Burket <[email protected]>
Signed-off-by: Matthew Burket <[email protected]>
Signed-off-by: Matthew Burket <[email protected]>
          
WalkthroughExpanded CI workflow triggers to run on pull_request, push, and merge_group. Disabled pre-commit autofix commits in configuration. Added CONTRIBUTING guide and DCO file. Updated README wording and added Contributing section referencing DCO. No functional code changes beyond CI trigger configuration. Changes
 Sequence Diagram(s)sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub
  participant WF as Deploy Workflow
  Dev->>GH: push / open PR / merge group
  Note over GH: Events: pull_request, push, merge_group
  GH-->>WF: Trigger workflow
  rect rgb(230,240,255)
  note right of WF: Workflow steps unchanged
  WF->>WF: Run existing build/deploy jobs
  end
  WF-->>GH: Report status
    Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
 Pre-merge checks and finishing touches❌ Failed checks (1 warning)
 ✅ Passed checks (2 passed)
 ✨ Finishing touches🧪 Generate unit tests
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️  Outside diff range comments (1)
CONTRIBUTING.md (1)
67-71: Fix Markdown formatting and typos in the contribution checklist.The inline code formatting for “-s” is missing a closing backtick, and “pull reqeust” is misspelled. These issues break the rendered formatting. Please update the line to something like “Please sign off (using
-sor--sign-off).” and fix “pull request.”
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
45-48: Correct the Windows section wording.Line 46 currently reads “It is sugguested…”. Please correct the spelling (“suggested”) so the guidance stays professional.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
 
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
.github/workflows/deploy.yaml(1 hunks).pre-commit-config.yaml(1 hunks)CONTRIBUTING.md(1 hunks)DCO(1 hunks)README.md(3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CONTRIBUTING.md
33-33: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
34-34: Dollar signs used before commands without showing output
(MD014, commands-show-output)
35-35: Dollar signs used before commands without showing output
(MD014, commands-show-output)
36-36: Dollar signs used before commands without showing output
(MD014, commands-show-output)
40-40: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
41-41: Dollar signs used before commands without showing output
(MD014, commands-show-output)
69-69: Spaces inside code span elements
(MD038, no-space-in-code)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy
 
Summary by CodeRabbit
Documentation
Chores