PoC: Replace esbuild with tsc #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-ac-martin
force-pushed
the
build-with-tsc
branch
from
91a60fe to
416d434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proof of concept for replacing esbuild with simple calls to tsc.
I think this would address: #208
It is an alternative to: #230
That all said, there is a view that 'dual packages' (CJS + ESM) are a bad idea, and that it is better to provide a slim ESM wrap around CJS code. See: https://nodejs.org/api/packages.html#dual-package-hazard
I've not tested this extensively, so it would be best to inspect the built files to check that it is doing what is required.
This approach also increases the size of the built package a bit. (Though there's probably an opportunity to remove some of the type files.)