Beacon sync update peer connection mgmnt #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why More intuitive names for assigned error types
why Explicitly check for block headers or blocks to unstage queued block headers or blocks. Not explicitly unstaging might lead to unnecessary (maybe small) delays when ending the header or block sync phase.
why When there are more than enough peers available to fetch data simultaneously, only those are selected that are unknown or have shown higher throughput when fetching.
why There is no need to zombify sync peers unless they deliver ostensibly bogus data. With zero response, only throughput statistics will be affected if a peer responses in time. Low throughput will leave a peer available but ignored if there are other peers with higher throughput unless all peers can run parallel.
why When most higher throughputs are equal then case all ranks must be the topmost rank (an not the least.) Otherwise one might have delays until the situation is resolved.
why Previously, syncer peers that did not deliver and ran in a timeout were not marked degraded (for ranking) but rather the error count increased. As a consequence, these peers did not lose with ranking. This led these peers linger on and tried again until the error count threshold was reached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.