Skip to content

portal: remove dead Nothing type and unreachable request branch #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

portal: remove dead Nothing type and unreachable request branch #3757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions portal/network/beacon/beacon_light_client_manager.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ logScope:
topics = "beacon_lc_man"

type
Nothing = object
ResponseError = object of CatchableError

NetRes*[T] = Result[T, void]
Expand Down Expand Up @@ -173,11 +172,7 @@ proc workerTask[E](
): Future[bool] {.async: (raises: [CancelledError]).} =
var didProgress = false
try:
let value =
when E.K is Nothing:
await E.doRequest(self.network)
else:
await E.doRequest(self.network, key)
let value = await E.doRequest(self.network, key)
if value.isOk:
for val in value.get().values:
let res = await self.valueVerifier(E)(val)
Expand Down