limit encode/decode/etc to types declared by serializationFormat
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These popular names easily fall afoul of ambiguous symbol resolution conflicts, such as when stew/base64 is imported alongside a serialization format and the right arguments are passed
arnetheduck
added a commit
to status-im/nim-json-serialization
that referenced
this pull request
Jul 23, 2025
For better forward compat with changes in nim-serialization, such as status-im/nim-serialization#84
jangko
pushed a commit
to status-im/nim-json-serialization
that referenced
this pull request
Jul 24, 2025
For better forward compat with changes in nim-serialization, such as status-im/nim-serialization#84
etan-status
added a commit
that referenced
this pull request
Jul 30, 2025
#84 removed a workaround for a Nim bug that required duplication of the `decode` template. This removal was not mentioned in the PR, so may be unintentional. However, the underlying problem is still there, and is surfaced when trying to compile `nim-ssz-serialization`'s tests. ``` /nim-ssz-serialization/tests/test_ssz_union.nim(137, 18) Error: type mismatch Expression: decode(SSZ, encoded, TestCaseObject) [1] SSZ: typedesc[SSZ] [2] encoded: array[0..0, byte] [3] TestCaseObject: typedesc[TestCaseObject] Expected one of (first mismatch at [position]): [2] template decode(Format: type SerializationFormat; input: string | openArray[char] | seq[byte] | openArray[byte]; RecordType: type; params: varargs[untyped]): auto ``` Re-applying the workaround fixes this problem.
etan-status
added a commit
that referenced
this pull request
Jul 30, 2025
#84 removed a workaround for a Nim bug that required duplication of the `decode` template. This removal was not mentioned in the PR, so may be unintentional. However, the underlying problem is still there, and is surfaced when trying to compile `nim-ssz-serialization`'s tests. ``` /nim-ssz-serialization/tests/test_ssz_union.nim(137, 18) Error: type mismatch Expression: decode(SSZ, encoded, TestCaseObject) [1] SSZ: typedesc[SSZ] [2] encoded: array[0..0, byte] [3] TestCaseObject: typedesc[TestCaseObject] Expected one of (first mismatch at [position]): [2] template decode(Format: type SerializationFormat; input: string | openArray[char] | seq[byte] | openArray[byte]; RecordType: type; params: varargs[untyped]): auto ``` Re-applying the workaround fixes this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These popular names easily fall afoul of ambiguous symbol resolution conflicts, such as when stew/base64 is imported alongside a serialization format and the right arguments are passed