Skip to content

Avoid write float alloc #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

Avoid write float alloc #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c904ce3
Avoid write float alloc
nitely Oct 8, 2025
92a24e8
test rountrip float
nitely Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions json_serialization/writer.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,9 +527,7 @@ proc writeValue*[V: not void](w: var JsonWriter, value: V) {.raises: [IOError].}
elif value is SomeFloat:
autoSerializeCheck(Flavor, SomeFloat, typeof(value)):
w.streamElement(s):
# TODO Implement writeText for floats
# to avoid the allocation here:
s.write $value
s.writeText value

elif value is seq or(value is distinct and distinctBase(value) is seq):
autoSerializeCheck(Flavor, seq, typeof(value)):
Expand Down
5 changes: 5 additions & 0 deletions tests/test_serialization.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,11 @@ suite "toJson tests":
"".toJson == "\"\""
"abc".toJson == "\"abc\""

test "float":
Json.roundtripTest 1.23, "1.23"
Json.roundtripTest 1.23'f32, "1.23"
Json.roundtripTest 1.23'f64, "1.23"

test "enums":
Json.roundtripTest x0, "\"x0\""
Json.roundtripTest x1, "\"x1\""
Expand Down