Skip to content

Fix missing escaping of backslashes in writing string value #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2025
Merged

Fix missing escaping of backslashes in writing string value #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
960ca42
Fix missing escaping of backslashes in writing string value
NagyZoltanPeter Oct 5, 2025
6022ff0
added test of backslash escaping
NagyZoltanPeter Oct 5, 2025
5725f63
Fix test_writer.nim formatting
NagyZoltanPeter Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions json_serialization/writer.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ template writeValueStringLike(w, value) =
of '\f': addPrefixSlash 'f' # \x0c
of '\r': addPrefixSlash 'r' # \x0d
of '"' : addPrefixSlash '\"'
of '\\': addPrefixSlash '\\'
of '\x00'..'\x07', '\x0b', '\x0e'..'\x1f':
s.write "\\u00"
s.write hexChars[(uint8(c) shr 4) and 0x0f]
Expand Down
1 change: 1 addition & 0 deletions tests/test_writer.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ suite "Test writer":

test "escapes":
check Json.encode("\x12") == """"\u0012""""
check Json.encode("""a\b""") == """"a\\b""""

test "Empty object":
type NoFields = object
Expand Down