Flavor automatic serialization rework #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the default handler is reduced to nothing if disabled. And it will be available when turned on in the caller module start from the callsite to all modules imported it.
arnetheduck
reviewed
Aug 11, 2025
| when value is JsonString: | ||
| autoSerializeCheck(Flavor, JsonString) | ||
| value = r.parseAsString() | ||
| autoSerializeCheck(Flavor, JsonString): |
There was a problem hiding this comment.
it feels like this check could be spelled as when autoSerializeCheck(...)
arnetheduck
reviewed
Aug 11, 2025
| r.raiseUnexpectedField(key, cstring typeName) | ||
|
|
||
| template autoSerializeCheck(F: distinct type, T: distinct type) = | ||
| template autoSerializeCheck(F: distinct type, T: distinct type, body) = |
There was a problem hiding this comment.
why is this helper in n-j-s and not in nim-serialization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the default handler is reduced to nothing if disabled.
And it will be available when turned on in the caller module
start from the callsite to all modules imported it.