Bugfix/signature replace and pydantic 2.10 #1855
Merged
+36
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you so much @mikeedjones ! |
isaacbmiller
pushed a commit
that referenced
this pull request
Dec 11, 2024
* feat(dspy): add datamodel-code-generator to dev reqs * fix(dspy): fix signature replace for pydantic v2.10 * fix(dspy): fix signature replace for pydantic v2.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic 2.10 includes a change to model_fields turning it into a property. Dspy's Signature.replace method cannot replace that property. This PR updates the replacement to also target
__pydantic_fields__.dspy/signatures/signature.pyfor better readability and maintainability.OldSignatureclass definition by removing the unnecessarySignaturebase class.requirements-dev.txtto include dependencydatamodel-code-generator==0.26.3and sorted reqs