Skip to content

Github Actions updates #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Github Actions updates #524

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2098ff2
ubuntu-latest is currently still 20.04. When Github deems 22.04 ready…
james-s-w-clark Jun 23, 2022
cbb6de7
checkout v3 will fetch less commits. We only need the one that trigge…
james-s-w-clark Jun 23, 2022
ad722fc
Use preinstalled python on github-hosted runner
james-s-w-clark Jun 23, 2022
95dd34f
pipx is baked into setup-python, no need to install
james-s-w-clark Jun 23, 2022
84c5dbf
run tests, lint etc. on PRs too
james-s-w-clark Jun 23, 2022
3b89bba
revert to ubuntu 20.04
james-s-w-clark Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/se-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,11 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.x-dev'
Copy link
Member

@acabal acabal Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove -dev from here, but in a ad722fc we specified 3.x-dev?

Copy link
Contributor Author

@james-s-w-clark james-s-w-clark Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried 3.x-dev as https://github.com/actions/setup-python#available-versions-of-python says that it'd get the latest patch version thanks to dev. It didn't exist in the manifest when I tried running the action locally with act though:

::error::Version 3.x-dev with arch x64 not found%0AThe list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

3.x seems to be the most common version I see for Github Actions, e.g. in the first basic snippet here https://github.com/actions/setup-python#usage.

One strange thing: https://github.com/actions/setup-python/releases/tag/v4.0.0 has a commit to fix the 3.x-dev syntax. I think the bug is unrelated to not parsing the version and finding best patch version in the manifest though 🤔

Copy link
Contributor Author

@james-s-w-clark james-s-w-clark Jun 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.11-dev works - it finds 3.11.0-beta.3

3.x gets python-3.10.5-linux-20.04-x64.tar.gz

Are you happy with 3.x (auto incrementing, and more stable), or prefer a fixed version with dev (bleeding edge for a short time, more maintenance, less stable)?

python-version: '3.x'
- name: Install Ubuntu packages
run: |
sudo apt update
sudo apt install calibre default-jre git python3-dev python3-pip python3-venv
- name: Install pipx
run: |
python3 -m pip install pipx
echo "PIPX_HOME=$HOME/pipx" >> $GITHUB_ENV
echo "PIPX_BIN_DIR=$HOME/pipx/bin" >> $GITHUB_ENV
echo "$HOME/pipx/bin" >> $GITHUB_PATH
sudo apt install calibre default-jre git python3-venv
- name: Install pipx packages
run: |
pipx install .
Expand Down