Skip to content

Aac client breaking #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 81 commits into
base: develop
Choose a base branch
from
Draft

Aac client breaking #6537

wants to merge 81 commits into from

Conversation

jferrant
Copy link
Contributor

Wanted to open this so I could point to it for Hiro, sBTC, etc. folks to see so they can prep for its eventual release.

Jiloc and others added 30 commits September 17, 2025 14:42
@Jiloc
rename InterpreterError -> VmInternalError
461ce80
@Jiloc
add docstring for VmInternalError and its variants
51180de
@Jiloc
cargo fmt
b285602
@Jiloc
add docstring for VmInternalError::BadSymbolicRepresentation(String)
0ccff9f
@Jiloc
rename VmInternalError::AssertionFailed -> InvariantViolation
632dd49
@Jiloc
fix stx_transfer_consolidate_regr_24010
5612c96
@kantai
Merge pull request #6499 from stacks-network/develop
5029abf 
merge develop -> aac-client-breaking
@jferrant
Rename ParseErrors to ParseErrorKind
00d2e17 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add comment descriptions to ParseErrorKind and its variants
6d4560f 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename ShortReturnType to EarlyReturnError
ad651d0 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename ShortReturn variant to EarlyReturn
7b14874 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add descriptions to EarlyReturnError
f063b24 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename CheckErrors to CheckErrorKind
d2a8832 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add descriptions to CheckErrorKind variants
a885af4 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename CheckError to StaticCheckError
0e23fda 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add descriptions to StaticCheckError and its components
5c54d4c 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename Error::Analaysis to Error::StaticCheck
de87cfa 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename clarity:src::vm::clarity::Error to ClarityError
750ccc5 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add descriptions to ClarityError and its variants
9dfc5b4 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename vm::errors::Error to VmExecutionError
e92b92e 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add descriptions to VmExecutionError and its variants
4b9257c 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Rename RuntimeErrorType to RuntimeError
a54136f 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Add descriptions to RuntimeError and its variants
ce98431 
Signed-off-by: Jacinta Ferrant <[email protected]>
@Jiloc
Merge branch 'aac-client-breaking' into chore/rename-interpreter-erro…
2172e01 
…r-to-vm-internal-error
@jferrant
Rename RuntimeError::ParseError to TypeParseFailure
62857b7 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
475d401 
… into aac-client-breaking
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
d0faa86 
… into chore/merge-develop-to-aac-client-breaking
@jferrant
CRC: fix bad comments
bdb5d9d 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
CRC: annotate all parameters
4774c6c 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
CRC: annotate all parameters
93d5090 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested review from a team as code owners September 25, 2025 16:32
@jferrant jferrant added aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change labels Sep 25, 2025
@jferrant jferrant requested a review from kantai September 25, 2025 16:32
@jferrant jferrant linked an issue Sep 25, 2025 that may be closed by this pull request
AAC Initial Cleanup: Rename and document error structs and variants #6453
Open
fdefelici
fdefelici reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jferrant Great idea!

What do you think about marking this as a draft instead? That way it’s clear we’re not ready to approve or merge it yet.

@Jiloc
Merge pull request #6538 from jferrant/chore/merge-develop-to-aac-cli…
962e7dd 
…ent-breaking

Chore/merge develop to aac client breaking
@jferrant jferrant marked this pull request as draft September 26, 2025 15:36
@fdefelici fdefelici mentioned this pull request Oct 9, 2025
Open
@fdefelici
Copy link
Contributor

Related issue: #6576

@fdefelici fdefelici moved this to Status: 💻 In Progress in Stacks Core Eng Oct 9, 2025
@fdefelici fdefelici linked an issue Oct 9, 2025 that may be closed by this pull request
aac: align with partners and merge client-breaking branch #6576
Open
jferrant and others added 10 commits October 10, 2025 14:51
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
e2b8471 
… into HEAD
@Jiloc
Merge pull request #6590 from jferrant/chore/merge-develop-to-aac-cli…
258e704 
…ent-breaking

Chore/merge develop to aac client breaking
@jferrant
Merge branch 'aac-client-breaking' of github.com:jferrant/stacks-core…
2b74579 
… into chore/merge-develop-to-aac-client-breaking
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
8f7df21 
… into merge-develop-to-aac-client-breaking
@jferrant
Merge branch 'merge-develop-to-aac-client-breaking' of github.com:jfe…
8d6248b 
…rrant/stacks-core into chore/merge-develop-to-aac-client-breaking
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
9c13b5f 
… into chore/merge-develop-to-aac-client-breaking
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
54f800b 
… into chore/merge-develop-to-aac-client-breaking
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
7f06876 
… into chore/merge-develop-to-aac-client-breaking
@jferrant
Add comments to the new error variants in CheckErrorKind
aeda2f6 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jacinta-stacks
Merge pull request #6596 from jferrant/chore/merge-develop-to-aac-cli…
c215d2b 
…ent-breaking

Chore/merge develop to aac client breaking
@jacinta-stacks jacinta-stacks requested review from aaronb-stacks, federico-stacks and francesco-stacks and removed request for kantai October 22, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jiloc Jiloc Awaiting requested review from Jiloc

@federico-stacks federico-stacks Awaiting requested review from federico-stacks

@francesco-stacks francesco-stacks Awaiting requested review from francesco-stacks

@aaronb-stacks aaronb-stacks Awaiting requested review from aaronb-stacks

1 more reviewer

@fdefelici fdefelici fdefelici left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change

Projects

Stacks Core Eng
Status: Status: 💻 In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aac: align with partners and merge client-breaking branch AAC Initial Cleanup: Rename and document error structs and variants

5 participants

@jferrant @fdefelici @Jiloc @kantai @jacinta-stacks