Fix "duplicate task" error #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use milliseconds to avoid duplicate task name
|
@marickvantuil can I please get feedback on this? Basically my app has many concurrent requests so just adding the timestamp with seconds still can lead to creating duplicate names. So I want to suggest using timestamp with milliseconds. Thanks! |
marickvantuil
added
the
safe-to-test
|
Thanks for the PR! Can you check the failing tests? Then I can merge it and make a new version. |
fix it_adds_a_task_name_based_on_the_display_name
github-actions
bot
removed
the
safe-to-test
fix retried_jobs_get_a_new_name
|
I made an attempt at a fix |
marickvantuil
added
the
safe-to-test
github-actions
bot
removed
the
safe-to-test
marickvantuil
added
the
safe-to-test
|
Tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use milliseconds to avoid duplicate task name. I am getting
The task cannot be created because a task with this name existed too recently. For more information about task de-duplication see https://cloud.google.com/tasks/docs/reference/rest/v2/projects.locations.queues.tasks/create#body.request_body.FIELDS.task.when running the app on version v3.6.0