Skip to content

chore: cleanup GA code and more #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2024
Merged

chore: cleanup GA code and more #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3580cb1
chore: remove now-unused VITE_GTAG_ID support
fvsch Mar 25, 2024
6449d84
chore: remove compiled .vitepress/config.ts.mjs file
fvsch Mar 25, 2024
bc373b9
Merge branch 'main' into fvsch/update-to-gtm
donmckenna Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 5 additions & 29 deletions .vitepress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,38 +129,14 @@ export default defineConfigWithTheme<ThemeConfig>({
},
});

function getAnalyticsTags({
VITE_GTM_ID = '',
VITE_GTAG_ID = '',
}: NodeJS.ProcessEnv): HeadConfig[] {
// Fail the build if we have a defined but malformed analytics id
const idPattern = /^(G|GTM)-[A-Z\d]+$/;
for (const [name, value] of Object.entries({ VITE_GTM_ID, VITE_GTAG_ID })) {
if (value && !idPattern.test(value)) {
throw new Error(`Invalid ${name} value: '${value}'`);
}
}

function getAnalyticsTags({ VITE_GTM_ID = '' }: NodeJS.ProcessEnv): HeadConfig[] {
const idPattern = /^GTM-[A-Z\d]+$/;
const tags: HeadConfig[] = [];

if (VITE_GTAG_ID) {
const source = `
window.dataLayer = window.dataLayer || [];
function gtag(){ dataLayer.push(arguments) }
gtag('js', new Date);
gtag('config', '${VITE_GTAG_ID}', { anonymize_ip: true });
`;
tags.push(['script', {}, source]);
if (!VITE_GTM_ID) {
const url = `https://www.googletagmanager.com/gtag/js?id=${VITE_GTAG_ID}`;
tags.push(['script', { async: '', src: url }]);
}
}

// We're migrating from gtag.js to gtm.js, but using both as we verify this change.
// According to https://support.google.com/tagmanager/answer/6103696 this should be
// inserted after any script declaring a dataLayer.
if (VITE_GTM_ID) {
if (!idPattern.test(VITE_GTM_ID)) {
throw new Error(`Invalid VITE_GTM_ID value: '${VITE_GTM_ID}'`);
}
const source = `
(function(w, d, s, l, i){
w[l] = w[l] || [];
Expand Down
Loading