Skip to content

chore: Enable strict mode for yamllint #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

Conversation

Techassi
Copy link
Member

Came up in the rollout of #544 (and other recent changes), eg. in stackabletech/airflow-operator#674.

@Techassi Techassi requested a review from NickLarsenNZ August 19, 2025 13:00
@Techassi Techassi self-assigned this Aug 19, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

It would pay to run pre-commit across a repo in the work/ directory if you haven't - just to avoid problems after rolling out.

@Techassi
Copy link
Member Author

It would pay to run pre-commit across a repo in the work/ directory if you haven't - just to avoid problems after rolling out.

I can do a run, but there will most likely be many errors of non-templated files. I will try to filter those out...

@Techassi
Copy link
Member Author

A rough looks seems to indicate that almost all the warnings/errors come from non-templated files. I suggest that we fix those in the downstream PRs once this PR is rolled out.

@NickLarsenNZ
Copy link
Member

I can do a run, but there will most likely be many errors of non-templated files. I will try to filter those out...

This would be exactly the same as running it on the resultant PR - just earlier. So if there are errors now, then there would be errors when the PRs are raised too.

A rough looks seems to indicate that almost all the warnings/errors come from non-templated files. I suggest that we fix those in the downstream PRs once this PR is rolled out.

Not sure I understand.

Are you doing:

# run templaing, then...
cd work/airflow-operator
pre-commit install --install-hooks
pre-commit run --from-ref main --to-ref HEAD

@Techassi
Copy link
Member Author

Not sure I understand.

I'm running both the command you suggested, but also without specifying the refs to see what other, non-templated files will be affected. The gist is: This PR looks fine for templated files, so is ready to go.

There however will be fallout for other non-templated files, because there are many YAML files which contain warnings/errors. Those however will only come up if touched.

@Techassi Techassi added this pull request to the merge queue Aug 20, 2025
Merged via the queue into main with commit dc98a00 Aug 20, 2025
2 checks passed
@Techassi Techassi deleted the chore/enable-strict-yamllint branch August 20, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants