Skip to content

Added option to allow the user the option of not using crate2nix but the default Docker build process instead #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added option to allow the user the option of not using crate2nix but the default Docker build process instead #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d625e23
Added option to allow the user the option of not using crate2nix but …
soenkeliebau Feb 14, 2023
2b7a726
Merge branch 'main' into feat/multiple_builders
soenkeliebau Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions template/Tiltfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,28 @@
# If tilt_options.json exists read it and load the default_registry value from it
# If tilt_options.json exists read it
settings = read_json('tilt_options.json', default={})
registry = settings.get('default_registry', 'docker.stackable.tech/sandbox')

# Configure default registry either read from config file above, or with default value of "docker.stackable.tech/sandbox"
registry = settings.get('default_registry', 'docker.stackable.tech/sandbox')
default_registry(registry)

# Configure which builder to use from config file, defaults to 'crate2nix'
builder = settings.get('builder', 'crate2nix')

meta = read_json('nix/meta.json')
operator_name = meta['operator']['name']

custom_build(
registry + '/' + operator_name,
'nix shell -f . crate2nix -c crate2nix generate && nix-build . -A docker --argstr dockerName "${EXPECTED_REGISTRY}/' + operator_name + '" && ./result/load-image | docker load',
deps=['rust', 'Cargo.toml', 'Cargo.lock', 'default.nix', "nix", 'build.rs', 'vendor'],
# ignore=['result*', 'Cargo.nix', 'target', *.yaml],
outputs_image_ref_to='result/ref',
)
if builder == 'crate2nix':
custom_build(
registry + '/' + operator_name,
'nix shell -f . crate2nix -c crate2nix generate && nix-build . -A docker --argstr dockerName "${EXPECTED_REGISTRY}/' + operator_name + '" && ./result/load-image | docker load',
deps=['rust', 'Cargo.toml', 'Cargo.lock', 'default.nix', "nix", 'build.rs', 'vendor'],
# ignore=['result*', 'Cargo.nix', 'target', *.yaml],
outputs_image_ref_to='result/ref',
)
else if builder == 'docker':
docker_build(registry + '/' + operator_name, '.', dockerfile='docker/Dockerfile')
else:
fail('Unsupported builder specified: [' + builder + '] - currently supported builders are: [docker, crate2nix]')

# Load the latest CRDs from Nix
watch_file('result')
Expand Down