Skip to content

Conversation

sbernauer
Copy link
Member

Description

As we want to start using stackable-webhook with #1066, we want to re-export it the same way as the other crates we have.
For that to work we need to resolve cyclic decencies operator -> certs -> operator and operator -> webhook -> operator.
I achieved this by moving common time and SecretRef code into stackable_shared.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer requested a review from Techassi July 10, 2025 09:08
@sbernauer sbernauer self-assigned this Jul 10, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 20, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 20, 2025
@sbernauer sbernauer requested a review from Techassi August 20, 2025 12:00
@sbernauer sbernauer requested review from Techassi and removed request for Techassi August 20, 2025 13:17
@sbernauer sbernauer force-pushed the feat/re-export-certs-and-webhook branch 2 times, most recently from 2be3dac to f8105ef Compare August 20, 2025 14:28
@sbernauer sbernauer added this pull request to the merge queue Aug 21, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 21, 2025
Merged via the queue into main with commit c00b9c5 Aug 21, 2025
8 checks passed
@sbernauer sbernauer deleted the feat/re-export-certs-and-webhook branch August 21, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants