-
Notifications
You must be signed in to change notification settings - Fork 8
Dependency updates #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates #139
Conversation
657d4cb to
1bd3d5b
Compare
|
@jonhealy1 I think the test errors come from stac-validator 3.10.0, maybe the new recursive validation introduced in stac-utils/stac-validator#265 ? Somewhat the relative links are not resolved correctly. For example when validating https://radarstac.s3.amazonaws.com/stac/radarsat-1/collection.json , it ends up by trying to access https://digital-atlas.s3.amazonaws.com/stac/public_stac/population/worldpop_2020/collection.json/pop_2020/pop_2020.json instead of https://digital-atlas.s3.amazonaws.com/stac/public_stac/population/worldpop_2020/pop_2020/pop_2020.json |
|
@vprivat-ads I think you're right. Definitely needs to be fixed. In stac-validator I meant to clean up the paths for display purposes but obviously wasn't careful enough. |
|
@vprivat-ads We should just be using Sphinx now. We build the docs when we push to github. I am not sure about the .rst files right now. The Readme should clearly be updated. Docs are published here: https://stac-utils.github.io/stac-check/ |
|
@vprivat-ads pdoc removal pr: #141. btw would you like to review some of these prs? |
jonhealy1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @vprivat-ads. Maybe just a changelog entry
|
@jonhealy1 thanks! Changelog updated :) |
jonhealy1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
Draft because there is one thing I don't understand concerning how to update the documentation. There are still mentions to pdoc in README.md, docs/api.rst and docs/cli.rst but I don't understand how to update the rst files once we have run pdoc.