Skip to content

Conversation

@donatj
Copy link
Collaborator

@donatj donatj commented Aug 22, 2023

So this sets up a basic GitHub action.

You can see it having ran and working here on the latest commit donatj/action-test#1

As written, it pulls the cs2pr file exclusively from the tag specified in the Dockerfile

ADD https://raw.githubusercontent.com/staabm/annotate-pull-request-from-checkstyle/1.8.5/cs2pr /usr/local/bin

This could be changed to use composer, I played with that and this is a pinch faster. The ultimate judgment on that is on you of course.


When this is merged into main, a Publish button should appear on the repo homepage. You'll use this to both tag and publish the first release.

You would create tags for your accepted commit as v1 v1.8 and v1.8.5

Future updates would replace the v1 tag and v1.8 if the new release was a 1.8.x release.

@donatj
Copy link
Collaborator Author

donatj commented Aug 22, 2023

I've appended some directions onto the PR message above. Let me know if you have any questions.

@staabm
Copy link
Owner

staabm commented Aug 23, 2023

thank you.

This could be changed to use composer, I played with that and this is a pinch faster.

if this means I don't need to manually update the dockerfile on every cs2pr release, then it would be a nice improvement.

it would be great I would not need to touch this repo often, as I have 0 experience with publishing an github action in this way :).

lets do it in a separate PR.

@staabm staabm merged commit 27b34f4 into staabm:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants