Use ReadExactly in ReadAllBytes and yield in ReadLines #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechNagorski
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SftpClient.ReadAllBytes does one call to SftpFileStream.Read. This is fine because SftpFileStream.Read currently fills the caller's buffer, but it may not always be the case, so for correctness we call ReadExactly (polyfilled on lower targets).
IEnumerable<string> ReadLinescurrently callsstring[] ReadAllLines. We invert this relationship so that ReadLines enumerates lazily. This is fine by contract but may cause behavioural breaks. Will call it out in release notes.