support DM encryption with metafeed crossovers #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
arj03
reviewed
Nov 12, 2022
Member
|
A first pass of comments, that should give you something to work with :) Overall the structure makes sense given our model. Exciting to see this coming along and I really like the legacy mode is kept there without complicating the code. |
Member
Author
|
The ssb-keyring PR is now up for review: https://gitlab.com/ahau/lib/ssb-keyring/-/merge_requests/18 |
arj03
reviewed
Nov 14, 2022
arj03
reviewed
Nov 14, 2022
arj03
reviewed
Nov 14, 2022
arj03
approved these changes
Nov 14, 2022
Member
arj03
left a comment
arj03
left a comment
There was a problem hiding this comment.
Found two minor nitpicks. Everything looks great now. Great work getting this done 🚀
Member
Author
|
@arj03 This PR is finally ready and tests passing. |
Member
Author
|
Oh, I see you already approved. Merging then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes box2 use ssb-meta-feeds to implement "2b funky recps" (spec pending). In other words, use the metafeed forest to do crossovers with "mirrored" feeds on the other peer's metafeed tree, to select the DM pairs.
Needs a locally hacked version of ssb-keyring that I haven't yet pushed or made a PR yet, so tests are all going to fail here in CI, but locally all tests are passing. I wanted to upload this PR first to get some reviews until (my) monday morning, e.g. @mixmix could review this on his monday morning.