feat: Adding support for dynamic view controller types #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation updates.
johnnewman-square
force-pushed
the
johnnewman/feature/dynamic-types
branch
from
1276ea8 to
ba762be
Compare
kyleve
reviewed
Aug 7, 2025
WorkflowUI/Sources/ViewControllerDescription/ViewControllerDescription.swift
Outdated
Show resolved
Hide resolved
kyleve
reviewed
Aug 7, 2025
WorkflowUI/Sources/ViewControllerDescription/ViewControllerDescription.swift
Show resolved
Hide resolved
kyleve
approved these changes
Aug 7, 2025
jamieQ
reviewed
Aug 11, 2025
WorkflowUI/Sources/ViewControllerDescription/ViewControllerDescription.swift
Show resolved
Hide resolved
watt
approved these changes
Aug 12, 2025
WorkflowUI/Sources/ViewControllerDescription/ViewControllerDescription.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to
ViewControllerDescriptionfor dynamic view controller types. This is used in cases where the static type of the description's view controller is not granular enough, like implementations that supply aUIViewController.selftype toViewControllerDescriptioninstead of the subclass type.This is behind a
DynamicControllerTypesSPI to encourage use of the existing initializer that uses generics.Checklist