Do not alter connection flow-control window on SETTINGS frame. #3920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might have been a difference between SPDY and HTTP/2. Reviewing the HTTP/2 spec, only a WINDOWS_UPDATE frame can change the flow-control window for a connection.
Collaborator
Author
|
I was doing some research on #3915 and noticed that after sending 16MiB of data on a stream the connection flow-control window was not 0. I've read the spec a few times now and think this is right but please confirm. It seems the idea of shrinking the connection window size is not really accounted for. |
Collaborator
|
That matches my reading of http://http2.github.io/http2-spec/index.html#InitialWindowSize |
yschimke
approved these changes
Mar 14, 2018
Collaborator
|
Nice find. Surprised how long we got away with this. |
This was referenced Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might have been a difference between SPDY and HTTP/2. Reviewing the
HTTP/2 spec, only a WINDOWS_UPDATE frame can change the flow-control
window for a connection.