Add support for DuckDB underscore numeric literals #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add numberRegex option to TokenizerOptions to allow custom number patterns - Update Tokenizer to use custom number regex when provided - Configure DuckDB formatter to support underscore separators in numbers (1_000_000) - Add test for underscore numeric literals in DuckDB
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks for the PR. Actually PostgreSQL supports the same syntax. Will make it work for both. |
|
Released in v15.6.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB allows underscores in numeric literals, e.g.
1_000_000. This PR adds support for this.numberRegexoption toTokenizerOptionsto allow custom number patternsTokenizerto use custom number regex when providedLet me know if you'd rather see this done differently! Thanks for the great library.