Add FOR UPDATE clause support for Postgres #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwalters512
commented
Mar 8, 2023
| 'LIMIT', | ||
| 'OFFSET', | ||
| 'FETCH {FIRST | NEXT}', | ||
| 'FOR {UPDATE | NO KEY UPDATE | SHARE | KEY SHARE} [OF]', |
There was a problem hiding this comment.
This was taken straight from the Postgres docs: https://www.postgresql.org/docs/current/sql-select.html
|
Thanks for the PR. Makes sense to me. |
|
Released in 12.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #421, but for Postgres.
IMO things look better if
OF(if present) is placed on the same like asFOR ...and any specific columns are placed on a separate line. I make this change for PL/SQL as well, but I'd be happy to revert that if you feel differently.