-
Notifications
You must be signed in to change notification settings - Fork 3
Teding/feat/compression #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thomaseding
commented
May 1, 2022
- Use actual Lua class syntax. (I finally read up on Lua 🎉)
- Avoids recording duplicate image sequences.
.lib/record-core.lua
Outdated
| -- * pollutes "recent files" | ||
| -- Anyway, this seems more than fast enough for human inputs. I tried lots | ||
| -- of very very fast changes on large detailed canvases, had no issues, and | ||
| -- have a computer that is average by 2022 standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill be sure to beat this up as I have a computer considered average by 2012 standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Ran through a gambit of:
- Image creation
- cropping
- painting
- fills
- moving
- resizing
|
Eeep!! I forgot to close the files I opened. Also check if any other potential file open call sites. EDIT: Done |
60ae3f9 to
8d4d409
Compare
Command Palette.lua
Outdated
| end | ||
|
|
||
| local path = get_recording_image_path_at_index(snapshot, 0) | ||
| local path = snapshot:get_recording_image_path_at_index(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| local path = snapshot:get_recording_image_path_at_index(0) | |
| local path = snapshot:get_recording_image_path(0) |
Method used is the old name, needs to be replaced with new one.
.lib/record-core.lua
Outdated
| -- NOTE(teding): Unfortunately `Image { fromFile = path }`: | ||
| -- * causes load popups | ||
| -- * pollutes "recent files" | ||
| -- Anyway, this seems more than fast enough for human inputs. I tried lots | ||
| -- of very very fast changes on large detailed canvases, had no issues, and | ||
| -- have a computer that is average by 2022 standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| -- NOTE(teding): Unfortunately `Image { fromFile = path }`: | |
| -- * causes load popups | |
| -- * pollutes "recent files" | |
| -- Anyway, this seems more than fast enough for human inputs. I tried lots | |
| -- of very very fast changes on large detailed canvases, had no issues, and | |
| -- have a computer that is average by 2022 standards. |
Can prune these comments from the code, is preferable to maintain these types of artifacts in PR comments for history tracking.
.lib/record-core.lua
Outdated
| -- This intentionally does not do anything "smart" such as scanning the | ||
| -- directory if gaps exist because that is O(N) at IO speeds and on every | ||
| -- snapshot (where N is the current snapshot index). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| -- This intentionally does not do anything "smart" such as scanning the | |
| -- directory if gaps exist because that is O(N) at IO speeds and on every | |
| -- snapshot (where N is the current snapshot index). |
Can prune these comments from the code, is preferable to maintain these types of artifacts in PR comments for history tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through a bunch of testing on my end, performance seems good. Just a few things that need to be addressed including an incorrect method reference.
|
@thomaseding Thanks for updating. Going to pull it down later today and do another pass through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaseding Everything looks good to me. Going to merge it in and get a release tagged and prepare an update to go out to itch. Thank you for contributing ![]()