Skip to content

Conversation

unix1982
Copy link
Contributor

Applied the change proposed on #8199

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 24, 2020
@eleftherias eleftherias self-assigned this Jun 24, 2020
@eleftherias eleftherias added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 24, 2020
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @unix1982!

I think we can go one step further, by merging the dependency table into each module section.
The structure would then look like this:

[[spring-security-core]]
== Core -- `spring-security-core.jar`
This module contains core ...

|===
| Dependency | Version | Description

| ehcache
| 1.6.2
| Required if the Ehcache-based user cache implementation is used (optional).
...

[[spring-security-remoting]]
== Remoting -- `spring-security-remoting.jar`

Then there is just the question of where the intro text "This section provides a reference of the modules in Spring Security and the additional dependencies that they require in order to function in a running application. We don't include ..." goes.

I think that could be moved under = Project Modules and Dependencies.
Then, we could get rid of dependencies.adoc completely.

@unix1982
Copy link
Contributor Author

I will do it! Thanks

@unix1982 unix1982 requested a review from eleftherias June 26, 2020 18:28
@eleftherias eleftherias added this to the 5.4.0-M2 milestone Jun 29, 2020
@eleftherias eleftherias merged commit 08b69e7 into spring-projects:master Jun 29, 2020
@eleftherias
Copy link
Contributor

Thanks for the PR @unix1982!
This is now merged into master.

@eleftherias eleftherias changed the title gh-8199 merged Spring security with dependencies Merge Spring security with dependencies Jun 29, 2020
@unix1982 unix1982 deleted the gh-8199 branch July 1, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants