Saml2AuthenticationRequestContext should be extendible #8356

[shazin]

Fixes issue #8356

[jzheaux]

Thanks, @shazin! Would you please squash your commits and format it to look something like:

Open Saml2AuthenticationRequestContext

Fixes gh-8356

For extra context, please see the contribution guidelines for squashing and formatting commits.

[shazin]

I tried squashing but it doesn't seem to show any commits to squash.

[jzheaux]

No problem, @shazin, let's try this.

Can you rebase your branch with master? For example, if you've defined the spring-projects/spring-security upstream as spring-projects and your own fork as origin, you can do this:

git checkout master
git reset --hard spring-projects/master
git push origin +master
git checkout gh-8356
git rebase master

At that point, a git log master.. should only return the commits on the gh-8356 branch that you've committed, and it won't have any merge commits.

At that point, doing something like git rebase -i gh-8356~x (where x is the number of commits to view) should show you a set of commits that makes sense to squash.

Once the commit list on the gh-8356 branch looks like you want it to, then you can do git push origin +gh-8356 and GitHub will update the PR here.

[shazin]

I Followed the instruction and now only one commit is visible. Thanks

[jzheaux]

Awesome, @shazin! This is now merged into master via 4e5a3a7