SAML AuthNRequest Signatures - Step 2 #7759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2019
fhanik
force-pushed
the
feature/authn_request_signatures
branch
2 times, most recently
from
683426f to
068679f
Compare
fhanik
changed the title
fhanik
added a commit
to fhanik/spring-security
that referenced
this pull request
Feb 11, 2020
…equest is signed Has been tested with - Keycloak - SSOCircle - Okta - SimpleSAMLPhp Further configuration options (POST vs REDIRECT) that build on top of this PR can be found in: spring-projects#7759 [fixes spring-projects#7711]
fhanik
force-pushed
the
feature/authn_request_signatures
branch
from
aa9cca6 to
6bdd5dd
Compare
jzheaux
requested changes
Feb 27, 2020
...g/springframework/security/saml2/provider/service/registration/RelyingPartyRegistration.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/saml2/provider/service/registration/RelyingPartyRegistration.java
Outdated
Show resolved
Hide resolved
...k/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationRequestFilter.java
Outdated
Show resolved
Hide resolved
jzheaux
added
status: duplicate
fhanik
force-pushed
the
feature/authn_request_signatures
branch
from
6bdd5dd to
e11e800
Compare
jzheaux
requested changes
Feb 27, 2020
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, I've left a bit more feedback.
...g/springframework/security/saml2/provider/service/registration/RelyingPartyRegistration.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/saml2/provider/service/registration/RelyingPartyRegistration.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/saml2/provider/service/registration/RelyingPartyRegistration.java
Outdated
Show resolved
Hide resolved
jzheaux
approved these changes
Feb 27, 2020
Has been tested with - Keycloak - SSOCircle - Okta - SimpleSAMLPhp This PR extends (builds on previous commits and adds user configuration options) spring-projects#7758
fhanik
force-pushed
the
feature/authn_request_signatures
branch
from
c7937d1 to
f460ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an implementation for
POST BINDINGforAuthNRequestmessages.Has been tested with
This PR extends (builds on previous commits and adds user configuration options)
#7758