Add RequestMatcher.matcher(HttpServletRequest) #7172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step 3 - Usage of RequestVariablesExtractor or types that are assigned to AntPathRequestMatcher should be replaced with the new method. [closes spring-projects#7148]
jzheaux
requested changes
Aug 2, 2019
There was a problem hiding this comment.
Thanks, @fhanik and @eddumelendez for this PR! I'll left some feedback inline about JavaDoc.
| } | ||
|
|
||
| /** | ||
| * The result of matching |
There was a problem hiding this comment.
Please add @since here as well.
web/src/main/java/org/springframework/security/web/util/matcher/RequestMatcher.java
Show resolved
Hide resolved
jzheaux
approved these changes
Aug 5, 2019
|
Thanks, @fhanik and @eddumelendez! This is now merged into |
rwinch
changed the title
jzheaux
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7148
Incorporates Commit from: #7150