Fix misleading variable name in authentication filter #17751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename DEFAULT_ANT_PATH_REQUEST_MATCHER to DEFAULT_PATH_REQUEST_MATCHER to reflect PathPatternRequestMatcher usage instead of legacy Ant pattern terminology. Signed-off-by: Jaehwan Lee <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: build
|
Thanks for the PR! This will be merged into main when the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename DEFAULT_ANT_PATH_REQUEST_MATCHER to DEFAULT_PATH_REQUEST_MATCHER to reflect PathPatternRequestMatcher usage instead of legacy Ant pattern terminology.
Description
This PR improves code clarity by fixing a misleading variable name in
UsernamePasswordAuthenticationFilterand removing outdated terminology.Problem
The current variable
DEFAULT_ANT_PATH_REQUEST_MATCHERincorrectly suggests that Ant pattern matching is being used, when the actual implementation usesPathPatternRequestMatcher. This naming inconsistency can confuse developers reading the code.Solution
Rename the variable to
DEFAULT_PATH_REQUEST_MATCHERto:PathPatternRequestMatcherimplementationChanges
DEFAULT_ANT_PATH_REQUEST_MATCHERtoDEFAULT_PATH_REQUEST_MATCHER