Avoid unnecessary instantiation of HttpSecurity #16370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
kse-music
force-pushed
the
pr11
branch
2 times, most recently
from
2623bf8 to
1de2f36
Compare
…Chain bean is provided Signed-off-by: DingHao <[email protected]>
Issue spring-projectsgh-16370 Signed-off-by: Rob Winch <[email protected]>
|
Thanks for the PR! I went ahead and rebased it and pushed a minor change b21850a. Once the build passes this will be merged into main. Thanks again for the PR 😄 |
rwinch
added
in: config
kwondh5217
pushed a commit
to kwondh5217/spring-security
that referenced
this pull request
Feb 4, 2025
Issue spring-projectsgh-16370 Signed-off-by: Rob Winch <[email protected]> Signed-off-by: Daeho Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ObjectProvider instead of @Autowired HttpSecurity because when the user provides a SecurityFilterChain bean, it will still inject HttpSecurity. Since HttpSecurity is a prototype bean, this avoids its instantiation.