Add support fullyAuthenticated to Kotlin DSL #16190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Thanks again, @franticticktick! I've left some feedback inline.
...t/kotlin/org/springframework/security/config/annotation/web/AuthorizeHttpRequestsDslTests.kt
Show resolved
Hide resolved
...c/main/kotlin/org/springframework/security/config/annotation/web/AuthorizeHttpRequestsDsl.kt
Show resolved
Hide resolved
franticticktick
force-pushed
the
gh-16162
branch
from
70e67e5 to
456f7f5
Compare
jzheaux
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Looking good, @franticticktick. I found two more items in the test if you could address them, please.
...t/kotlin/org/springframework/security/config/annotation/web/AuthorizeHttpRequestsDslTests.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/org/springframework/security/config/annotation/web/AuthorizeHttpRequestsDslTests.kt
Outdated
Show resolved
Hide resolved
jzheaux
added
in: config
franticticktick
force-pushed
the
gh-16162
branch
from
456f7f5 to
871deba
Compare
franticticktick
force-pushed
the
gh-16162
branch
from
871deba to
3bbc59a
Compare
|
@jzheaux thanks for feedback, all your comments have been resolved. |
jzheaux
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16162