Skip to content

Conversation

lukasdo
Copy link
Contributor

@lukasdo lukasdo commented Mar 5, 2024

For details see #14688

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 5, 2024
@marcusdacoregio
Copy link
Contributor

Hi, @lukasdo. Can you please squash your commits in preparation for merge?

@marcusdacoregio marcusdacoregio self-assigned this Mar 6, 2024
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 6, 2024
…assword link

spring-projectsGH-14688 Use inter-document xref to fix username and password link
@marcusdacoregio
Copy link
Contributor

@lukasdo, are you sure that the link you changed redirect to a page? I tested on my side and it returned Page Not Found. I believe that the link should redirect to https://docs.spring.io/spring-security/reference/servlet/authentication/passwords/input.html.

You can generate the documentation by following the steps in this guide.

@lukasdo
Copy link
Contributor Author

lukasdo commented Mar 6, 2024

@marcusdacoregio, I will check the documentation generation in a bit. However the link should be correct. I used the same link that is referenced on other pages e.g.: JDBC Authentication and LDAP Authentication

You are right in earlier working versions of the documentation the link seemed to be referencing the chapter Reading the Username & Password, although the section id should be leading to 10.10. Username/Password Authentication.
Additionally the DaoAuthenticationProvider page is referencing Reading the Username & Password in the text but linking to the Username/Password Authentication page.

Hope this is understandable...

@marcusdacoregio marcusdacoregio modified the milestone: 6.4.0-M1 May 24, 2024
@marcusdacoregio marcusdacoregio merged commit 3af85a5 into spring-projects:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants