GH-2609: providing more tracing tags #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* polish `ObservationTests`. * add @author. * add doc in `whats-new.adoc`.
Wzy19930507
force-pushed
the
GH-2609_2024
branch
from
18ed8a7 to
1ca8ac8
Compare
artembilan
requested changes
Apr 1, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Thank you for looking into this!
Please, find some my requests about improvements.
...fka/src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
Outdated
Show resolved
Hide resolved
...fka/src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/org/springframework/kafka/support/micrometer/KafkaRecordReceiverContext.java
Show resolved
Hide resolved
* add javadoc for `KafkaRecordReceiverContext` construct method.
artembilan
requested changes
Apr 2, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Just some minor clean ups according to our code style.
Thanks
...fka/src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
Outdated
Show resolved
Hide resolved
...fka/src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
Show resolved
Hide resolved
...fka/src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
Show resolved
Hide resolved
...fka/src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/org/springframework/kafka/support/micrometer/KafkaRecordReceiverContext.java
Show resolved
Hide resolved
...a/src/main/java/org/springframework/kafka/support/micrometer/KafkaRecordReceiverContext.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2609
detail see #2616.
ObservationTests.whats-new.adoc.