Add an option to leave consumer group when closing Streams #3168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juwit Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@juwit Thank you for signing the Contributor License Agreement! |
juwit
force-pushed
the
feature/leaveGroupOnClose
branch
from
15d31b3 to
61dc8dd
Compare
sobychacko
requested changes
Mar 28, 2024
spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java
Outdated
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java
Outdated
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java
Outdated
Show resolved
Hide resolved
juwit
force-pushed
the
feature/leaveGroupOnClose
branch
from
61dc8dd to
f674878
Compare
Contributor
Author
|
Thanks for the review @sobychacko 🙏 |
sobychacko
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi Spring-Kafka Team !
When developping with Kafka Streams, I figured that when shutting down an app, the consumer didn't seem to proactively leave the Kafka consumer group.
This seems to be related to a
leaveGroupparameter that wasn't used in theorg.apache.kafka.streams.KafkaStreams#close()method.So this PR adds support for this parameter, and documentation of the parameters in the Apache Kafka Streams Support section.