Remove org.apache.kafka native runtime hints #3147
Conversation
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
There is also a typo in the commit message about Spring for Apache Kafka version.
I believe it has to be the current one - 3.2
| // standard partitioners | ||
| org.apache.kafka.clients.producer.internals.DefaultPartitioner.class, | ||
| RoundRobinPartitioner.class, | ||
| org.apache.kafka.clients.producer.UniformStickyPartitioner.class, |
There was a problem hiding this comment.
Why do we still keep this Kafka client classes here?
There was a problem hiding this comment.
Missing in the metadata repo.
There was a problem hiding this comment.
Apparently both of these classes are deprecated now.
And according to their Javadocs they are not recommended to be used at all.
So, it is safe to remove them from here even now.
spring-kafka/src/main/java/org/springframework/kafka/aot/KafkaRuntimeHints.java
Show resolved
Hide resolved
* Since several of the native runtime hints that Spring for Apache Kafka provides for org.apahce.kafka classes are available via the graalvm-reachability-metadata repository (https://github.com/oracle/graalvm-reachability-metadata), we are no longer keeping these runtime hints in Spring for Apache Kafka since version 3.2.0. This applies to both kafka-client classes and Kafka Streams classes.
sobychacko
force-pushed
the
aot-runtime-hints-cleanup
branch
from
1dd1593 to
71cef5a
Compare
| // standard partitioners | ||
| org.apache.kafka.clients.producer.internals.DefaultPartitioner.class, | ||
| RoundRobinPartitioner.class, | ||
| org.apache.kafka.clients.producer.UniformStickyPartitioner.class, |
There was a problem hiding this comment.
Apparently both of these classes are deprecated now.
And according to their Javadocs they are not recommended to be used at all.
So, it is safe to remove them from here even now.
spring-kafka/src/main/java/org/springframework/kafka/aot/KafkaRuntimeHints.java
Show resolved
Hide resolved
2 participants
Uh oh!
There was an error while loading. Please reload this page.