Skip to content

Conversation

gigermocas
Copy link
Contributor

Fixes #3509

Dead connections are not being removed on TcpSender when using a TcpConnectionInterceptor
May cause a memory leak

@pivotal-issuemaster
Copy link

@gigermocas Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@gigermocas Thank you for signing the Contributor License Agreement!

Fixes spring-projects#3509

Dead connections are not being removed on `TcpSender` when using a `TcpConnectionInterceptor`
May cause a memory leak
@gigermocas
Copy link
Contributor Author

I messed up, pull request should be based on my own issue branch, instead of master, is this fixable?

@artembilan
Copy link
Member

No, that's OK. We still can review and merge it.
You will just need to do git reset --hard upsteam/master for your local copy after we merge this PR.
Will review it shortly.
Thanks

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far!
Pulling locally for final review and possible clean up, e.g. add you name to the @author list of all the affected classes.

@artembilan
Copy link
Member

Merged and cherry-picked to 5.4.x as 78a0ae8 after some clean up.

Thank you for contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak through TcpSendingMessageHandler's connections map

3 participants