RedisLockRegistry stopRenew not thread safe #10446 #10467
Conversation
Closes spring-projects#10446 Signed-off-by: PiotrDuz <[email protected]> Signed-off-by: PiotrDuz <[email protected]>
There was a problem hiding this comment.
Signed-off-by: PiotrDuz <[email protected]>
Please, consider to use your legal name and real email.
For DCO requirements.
|
Hey, So I wouldn't like to post my personal data open in the web. And all the details match ym account , also I sign it from the same account that authored the commit - then there is little room to claim that author has not agreed on the terms. Would it be ok ? :> |
|
OK, @PiotrDuz , Got an answer from our management. Now I can review and merge your PR. Thank you for your patience! |
| return res; | ||
| } | ||
|
|
||
| /* This method can be called by more than 1 thread, thus we need to make sure that it is safe*/ |
There was a problem hiding this comment.
We don't need this comment here.
Because it is obvious from the method and property scope that it is a bug with concurrent access.
Therefore, we follow "local variable extraction" pattern everywhere in similar situations.
Please, remove this comment altogether.
There was a problem hiding this comment.
/home/runner/work/spring-integration/spring-integration/spring-integration-redis/src/test/java/org/springframework/integration/redis/outbound/RedisQueueOutboundChannelAdapterTests.java:134: error: cannot find symbol
handler.setSerializer(new Jackson3JsonRedisSerializer<Object>(Object.class));
^
symbol: class Jackson3JsonRedisSerializer
location: class RedisQueueOutboundChannelAdapterTests
Please, consider to rebase your branch to the latest upstream/main.
We have the fix for that Spring Data change in already.
2 participants
Closes #10446
Makes stopRenew() method thread safe.
Signed-off-by: PiotrDuz [email protected]