SPR-15107 Updating MySQLMaxValueIncrementer to not rely on MYISAM #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisberg
force-pushed
the
SPR-15107
branch
2 times, most recently
from
8dec85c to
420d0d6
Compare
Member
Author
|
Rebased and squashed the commits. Added a |
trisberg
force-pushed
the
SPR-15107
branch
3 times, most recently
from
6f153fb to
7500ab7
Compare
We should no longer rely on MYISAM for the sequence table since this engine might not always be available. After this change the storage engine used by the sequence table can be MYISAM or INNODB since the sequences are allocated using a new connection without being affected by any other transactions that might be in progress. To allow users to fall back on the original functionality of using MYISAM tables for the incrementer, we add a `useNewConnection` flag to indicate whether or not to use a new connection for the incrementer. This flag defaults to true. Issue: SPR-15107
Member
Author
|
We might consider having the default for "useNewConnection" to be false in 4.3.x to maintain backwards compatibility and then flip that to true in 5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should no longer rely on MYISAM for the sequence table since this
engine might not always be available. After this change the storage
engine used by the sequence table can be MYISAM or INNODB since the
sequences are allocated using a separate connection without being
affected by any other transactions that might be in progress.
Issue: SPR-15107