@EnableTransactionManagement and co should also get detected on superclasses [SPR-10864]

[spring-projects-issues]

Neale Upstone opened SPR-10864 and commented

Annotating a super-class with @EnableTransactionManagement results in the following exception message: @EnableTransactionManagement is not present on importing class ConcreteClass

This is a complete gotcha when someone will get from trying to be DRY.

It seems that the only way to cause this is to import a class that extends one with the annotation.

If this is the case, then I suggest that the exception should point to the Javadoc of @EnableTransactionManagement, and that the Javadoc should explain why it is not @Inherited.

---

Issue Links:

• @Enable registrars invoked with subclass for annotation placed on superclass (3.2.x) [SPR-11251] #15876 @Enable registrars invoked with subclass for annotation placed on superclass (3.2.x)

Referenced from: commits ce917d5, e8dead2

[spring-projects-issues]

Juergen Hoeller commented

After a bit of research, I'm redefining this issue to actually support the detection of @EnableTransactionManagement and co on superclasses. There doesn't seem to be a conceptual reason not to do so, and with a bit of internal refactoring, it works smoothly.

So as of Spring 4.0, we officially support @Enable* annotations on @Configuration superclasses. Note that @Enable* annotations still aren't marked as @Inherited; we process them on the actual superclass, which means participating in the detection of reoccuring superclasses etc, just like we do for regular @Configuration processing.

Juergen