Upgrading to Spring Data JDBC 2.1.3 results in ConverterNotFoundException for String to Duration

[dmkeen]

I have a Spring Data repository that returns an object with a Duration field which is stored in the database as a String. In Spring Data JDBC 2.1.2 the object is created and returned successfully. After upgrading to Spring Data JDBC 2.1.3, the following exception is thrown:

org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [java.lang.String] to type [java.time.Duration]

I've created a project that demonstrates the issue here: https://github.com/dmkeen/spring-boot-2.4.2-issue

Because the issue presented itself when upgrading Spring Boot, I filed an issue there first. Scott Frederick helped narrow down the problem - please see his analysis here: spring-projects/spring-boot#25878.

[schauder]

I strongly suspect this is a duplicate of spring-projects/spring-data-commons#2223

You should be able to fix this by registering some custom conversion for the conversion from String to Duration and back.

[mp911de]

Attaching stack trace:

org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [java.lang.String] to type [java.time.Duration]

	at org.springframework.core.convert.support.GenericConversionService.handleConverterNotFound(GenericConversionService.java:322)
	at org.springframework.core.convert.support.GenericConversionService.convert(GenericConversionService.java:195)
	at org.springframework.core.convert.support.GenericConversionService.convert(GenericConversionService.java:175)
	at org.springframework.data.relational.core.conversion.BasicRelationalConverter.getPotentiallyConvertedSimpleRead(BasicRelationalConverter.java:241)
	at org.springframework.data.relational.core.conversion.BasicRelationalConverter.readValue(BasicRelationalConverter.java:164)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter.readValue(BasicJdbcConverter.java:244)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter$ReadingContext.readFrom(BasicJdbcConverter.java:488)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter$ReadingContext.readOrLoadProperty(BasicJdbcConverter.java:457)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter$ReadingContext.populateProperties(BasicJdbcConverter.java:436)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter$ReadingContext.createInstanceInternal(BasicJdbcConverter.java:568)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter$ReadingContext.mapRow(BasicJdbcConverter.java:414)
	at org.springframework.data.jdbc.core.convert.BasicJdbcConverter.mapRow(BasicJdbcConverter.java:348)
	at org.springframework.data.jdbc.core.convert.EntityRowMapper.mapRow(EntityRowMapper.java:67)

[schauder]

We should properly support the JSR310 converters in Spring Data JDBC.

This is probably already fixed by #937 for the current master

[dmkeen]

Thanks for looking into this!

You should be able to fix this by registering some custom conversion for the conversion from String to Duration and back

I was hoping I wouldn't have to! :)

This is probably already fixed by #937 for the current master

I see that this PR is included in Spring Data 2021.0.0, so I've tested with Spring Boot 2.5.0-RC1 (which includes 2012.0.0) and the issue is resolved. Thanks!

[schauder]

Closing this as a duplicate of #937