Fix HGETDEL, HGETEX and HSETEX pipeline and transaction integration tests. #3246
+29
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests. Signed-off-by: viktoriya.kutsarova <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Oct 24, 2025
| assertThat(connection.hGet("hash-hsetex", "field-1")).isEqualTo("value-1"); | ||
| assertThat(connection.hGet("hash-hsetex", "field-2")).isEqualTo("value-2"); | ||
| actual.add(connection.hSetEx("hash-hsetex", fieldMap, RedisHashCommands.HashFieldSetOption.upsert(), | ||
| Expiration.seconds(2))); |
There was a problem hiding this comment.
Can you use higher timeout values? CI sometimes needs a longer time and two seconds are a bit tight. Something like 30 seconds should be sufficient.
There was a problem hiding this comment.
Of course.
Signed-off-by: viktoriya.kutsarova <[email protected]>
mp911de
added a commit
that referenced
this pull request
Oct 24, 2025
Fix assertions, simplify tests, reduce test method visibility. See #3246
mp911de
pushed a commit
that referenced
this pull request
Oct 24, 2025
…tion tests. Signed-off-by: viktoriya.kutsarova <[email protected]> Closes #3246
mp911de
added a commit
that referenced
this pull request
Oct 24, 2025
Fix assertions, simplify tests, reduce test method visibility. See #3246
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the pipeline and transaction tests for the HGETDEL, HGETEX and HSETEX.