maven-plugin aot test mojo: process aot when tests are built but not run

[stevenschlansker]

Currently, it is not possible to build the tests AOT processing without running them. Maven Surefire provides two different configuration switches:

• skipTests builds, but does not run, tests
• maven.test.skip neither builds nor runs tests

Right now the spring boot aot processing will skip aot in both cases. However, there's reasons to build but not run tests: in particular, this breaks reproducible builds because the main run (with tests built and run) has the aot classes built, but then the reproducer run (build tests but skip running them) does not, leading to different test jars.

In the case where tests are built but not run, we should still do AOT processing, since that is part of producing the full test jar.

We'd very much appreciate a backport to 3.5.x if possible

[hgschmie]

I'd argue that this would be better served by adding a new configuration option that uses the value of the maven.test.skip property as its default.

That way, the code would still behave as before but a developer can control whether processing is skipped or not by overriding the default behavior.

<skipAotTestProcessing>${maven.test.skip}</skipAotTestProcessing>

[snicoll]

Currently, it is not possible to build the tests AOT processing without running them.

I am not sure that I got that, given that the "running them" part is done by a different plugin. Please refer to the Native Maven Plugin documentation.

I added this in a demo project and AOT did run, but the tests did not:

<profile>
	<id>nativeSkipTests</id>
	<build>
		<plugins>
			<plugin>
				<groupId>org.graalvm.buildtools</groupId>
				<artifactId>native-maven-plugin</artifactId>
				<executions>
					<execution>
						<id>native-test</id>
						<configuration>
							<skipNativeTests>true</skipNativeTests>
						</configuration>
					</execution>
				</executions>
			</plugin>
		</plugins>
	</build>
</profile>

The documentation I refered to offers a command line switch as well.

Can you clarify what this PR is supposed to do?

[stevenschlansker]

Thanks for the example - I think it's not the same as my use case. In your example, "normal" surefire still runs, and then native tests are skipped. In this case, we are trying to skip normal surefire as well as native tests, with -DskipTests. Or did I miss something?

[snicoll]

Did I miss something?

Have you reviewed my previous comment that states our plugin does not execute the native tests? Does that PR of yours actually work? Have you tried it?

Regardless, it makes no sense for us to bind to a surefire plugin-specify property, especially when our plugin doesn't do anything with test execution. The maven.test.skip property is more general and honored by at least Surefire, Failsafe and the Compiler Plugins. It then makes sense to support it since our process-test-aot is compiling generated test code.

All in all, I don't think you've reviewed this thoroughly, and I can't see how the changes you've suggested is helping the scenario you've described.

[snicoll]

On second thought, let's continue the conversation on #46929 - This PR is nowhere near the changes we'd apply anyways.