ConfigDataLocationResolvers and PropertySourceLoaders are loaded using a potentially different class loader

[wilkinsona]

ConfigDataLocationResolver implementations are loaded using the resource loader's ClassLoader

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/ConfigDataEnvironment.java

Lines 157 to 161 in 5e57f1b

	protected ConfigDataLocationResolvers createConfigDataLocationResolvers(DeferredLogFactory logFactory,
	ConfigurableBootstrapContext bootstrapContext, Binder binder, ResourceLoader resourceLoader) {
	return new ConfigDataLocationResolvers(logFactory, bootstrapContext, binder, resourceLoader,
	SpringFactoriesLoader.forDefaultResourceLocation(resourceLoader.getClassLoader()));
	}

One of these implementations, StandardConfigDataLocationResolver, then uses its class's own class loader to load PropertySourceLoader implementations:

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/StandardConfigDataLocationResolver.java

Lines 86 to 93 in 5e57f1b

	public StandardConfigDataLocationResolver(DeferredLogFactory logFactory, Binder binder,
	ResourceLoader resourceLoader) {
	this.logger = logFactory.getLog(StandardConfigDataLocationResolver.class);
	this.propertySourceLoaders = SpringFactoriesLoader.loadFactories(PropertySourceLoader.class,
	getClass().getClassLoader());
	this.configNames = getConfigNames(binder);
	this.resourceLoader = new LocationResourceLoader(resourceLoader);
	}

For consistency, it should use the ResourceLoader that's passed into its constructor instead.

[alexisgayte]

Hi @wilkinsona,

Just to let you know,
I believe that was used to load a xml resource from another jar.

This has created a regression altho I would agree we were using internal things.

Thanks for your hard work.

[wilkinsona]

Apologies for the breakage, @alexisgayte, and thanks for letting us know. I'm not sure if you'd like us to investigate further. If you would, please open a new issue with a minimal sample that works without this change and fails with it.

[alexisgayte]

No problem,
I don't think it needs to be investigated. Just for you to know about it / keep in mind.