Fix Compressed contentEncoding Delimiter #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#1251 Delimiter should be a comma and whitespace trimmeed. Handle both delimiters in decompressors and add property for backwards compatibility. **I will backport to 2.2.x with default `:`**
|
Back ported to 2.2.x with flipped default as d73e6ae |
garyrussell
added a commit
to garyrussell/spring-amqp
that referenced
this pull request
Sep 28, 2020
Resolves spring-projects#1253 Misleading field name `standardCharset`. It was meant to convey that Jackson's default charset (UTF-8) is being used and so we can convert directly to `byte[]`. Otherwise we convert to `String` and then to `byte[]` using the configured charset. Also, it was not set to `true` by default.
artembilan
pushed a commit
that referenced
this pull request
Sep 28, 2020
Resolves #1253 Misleading field name `standardCharset`. It was meant to convey that Jackson's default charset (UTF-8) is being used and so we can convert directly to `byte[]`. Otherwise we convert to `String` and then to `byte[]` using the configured charset. Also, it was not set to `true` by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1251
Delimiter should be a comma and whitespace trimmeed.
Handle both delimiters in decompressors and add property for backwards compatibility.
I will backport to 2.2.x with default
: